X-Git-Url: http://git.localhorst.tv/?a=blobdiff_plain;f=src%2Fbattle%2FBattleState.cpp;h=36b4af53752714d58d1fc356230709b2aeaec988;hb=cc3d698b8c1ad09d7a3f9e3f28bc84e0ac1735ea;hp=3dea5b4c5f40c9cad6f88ce6055df1d90ae0b84e;hpb=51c5ffb4958968827b93624f7849c1b7d3a1eacb;p=l2e.git

diff --git a/src/battle/BattleState.cpp b/src/battle/BattleState.cpp
index 3dea5b4..36b4af5 100644
--- a/src/battle/BattleState.cpp
+++ b/src/battle/BattleState.cpp
@@ -1,10 +1,3 @@
-/*
- * BattleState.cpp
- *
- *  Created on: Aug 5, 2012
- *      Author: holy
- */
-
 #include "BattleState.h"
 
 #include "PartyLayout.h"
@@ -12,15 +5,17 @@
 #include "states/PerformAttacks.h"
 #include "../app/Application.h"
 #include "../app/Input.h"
+#include "../common/GameState.h"
 #include "../common/Ikari.h"
 #include "../common/Inventory.h"
 #include "../common/Item.h"
 #include "../common/Spell.h"
-#include "../geometry/operators.h"
 #include "../graphics/Frame.h"
 #include "../graphics/Sprite.h"
 
 #include <algorithm>
+#include <cassert>
+#include <cstdlib>
 #include <stdexcept>
 
 using app::Application;
@@ -28,10 +23,11 @@ using app::Input;
 using common::Inventory;
 using common::Item;
 using common::Spell;
-using geometry::Point;
+using common::Stats;
 using geometry::Vector;
 using graphics::Menu;
 
+using std::rand;
 using std::vector;
 
 namespace battle {
@@ -58,138 +54,63 @@ void BattleState::NextHero() {
 	}
 }
 
+void BattleState::PreviousHero() {
+	--activeHero;
+	while (activeHero >= 0 && heroes[activeHero].Health() == 0) {
+		--activeHero;
+	}
+}
+
 void BattleState::SwapHeroes(int lhs, int rhs) {
 	if (lhs < 0 || lhs >= numHeroes || rhs < 0 || rhs >= numHeroes || lhs == rhs) return;
 	std::swap(heroes[lhs], heroes[rhs]);
 }
 
 
-void BattleState::Resize(int w, int h) {
+void BattleState::OnResize(int w, int h) {
 
 }
 
 
-void BattleState::EnterState(Application &ctrl, SDL_Surface *screen) {
-	monstersLayout->CalculatePositions(background->w, background->h, monsterPositions);
-	heroesLayout->CalculatePositions(background->w, background->h, heroesPositions);
+void BattleState::OnEnterState(SDL_Surface *screen) {
 	for (int i(0); i < 4; ++i) {
-		spellMenus[i] = res->spellMenuPrototype;
-		LoadSpellMenu(i);
-		ikariMenus[i] = res->ikariMenuPrototype;
-		LoadIkariMenu(i);
+		heroes[i].Position() = heroesLayout->CalculatePosition(i, background->w, background->h);
+		heroes[i].SpellMenu() = *res->spellMenuProperties;
+		heroes[i].UpdateSpellMenu();
+		heroes[i].IkariMenu() = *res->ikariMenuProperties;
+		heroes[i].UpdateIkariMenu(res);
 		heroTags[i] = HeroTag(this, i);
 		smallHeroTags[i] = SmallHeroTag(this, i);
 	}
 
+	for (int i(0); i < int(monsters.size()); ++i) {
+		monsters[i].Position() = monstersLayout->CalculatePosition(i, background->w, background->h);
+	}
+
 	int tagHeight(attackTypeMenu.Height());
 	int tagWidth(attackTypeMenu.Width() * 2 + attackTypeMenu.Width() / 2);
 	int xOffset((Width() - 2 * tagWidth) / 2);
-	heroTagPositions[0] = Point<int>(xOffset, Height() - 2 * tagHeight);
-	heroTagPositions[1] = Point<int>(xOffset + tagWidth, Height() - 2 * tagHeight);
-	heroTagPositions[2] = Point<int>(xOffset, Height() - tagHeight);
-	heroTagPositions[3] = Point<int>(xOffset + tagWidth, Height() - tagHeight);
+	heroTagPositions[0] = Vector<int>(xOffset, Height() - 2 * tagHeight);
+	heroTagPositions[1] = Vector<int>(xOffset + tagWidth, Height() - 2 * tagHeight);
+	heroTagPositions[2] = Vector<int>(xOffset, Height() - tagHeight);
+	heroTagPositions[3] = Vector<int>(xOffset + tagWidth, Height() - tagHeight);
 
 	tagHeight = res->normalFont->CharHeight() * 4 + res->smallHeroTagFrame->BorderHeight() * 2;
 	tagWidth = res->normalFont->CharWidth() * 6 + res->smallHeroTagFrame->BorderWidth() * 2;
 	xOffset = (Width() - 4 * tagWidth) / 2;
 	int yOffset(Height() - tagHeight);
-	smallHeroTagPositions[0] = Point<int>(xOffset, yOffset);
-	smallHeroTagPositions[1] = Point<int>(xOffset + 2 * tagWidth, yOffset);
-	smallHeroTagPositions[2] = Point<int>(xOffset + tagWidth, yOffset);
-	smallHeroTagPositions[3] = Point<int>(xOffset + 3 * tagWidth, yOffset);
+	smallHeroTagPositions[0] = Vector<int>(xOffset, yOffset);
+	smallHeroTagPositions[1] = Vector<int>(xOffset + 2 * tagWidth, yOffset);
+	smallHeroTagPositions[2] = Vector<int>(xOffset + tagWidth, yOffset);
+	smallHeroTagPositions[3] = Vector<int>(xOffset + 3 * tagWidth, yOffset);
 
-	itemMenu = res->itemMenuPrototype;
+	itemMenu = *res->itemMenuProperties;
 	LoadInventory();
-}
-
-void BattleState::LoadSpellMenu(vector<Hero>::size_type index) {
-	spellMenus[index].Clear();
-	spellMenus[index].Reserve(HeroAt(index).Spells().size());
-	for (vector<const Spell *>::const_iterator i(HeroAt(index).Spells().begin()), end(HeroAt(index).Spells().end()); i != end; ++i) {
-		bool enabled((*i)->CanUseInBattle() && (*i)->Cost() <= HeroAt(index).Mana());
-		spellMenus[index].Add((*i)->Name(), *i, enabled, 0, (*i)->Cost());
-	}
-}
-
-void BattleState::LoadIkariMenu(vector<Hero>::size_type index) {
-	ikariMenus[index].Clear();
-	ikariMenus[index].Reserve(6);
-
-	if (HeroAt(index).HasWeapon()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Weapon()->Name(),
-				HeroAt(index).Weapon(),
-				HeroAt(index).Weapon()->HasIkari() && HeroAt(index).Weapon()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->weaponMenuIcon,
-				0,
-				HeroAt(index).Weapon()->HasIkari() ? HeroAt(index).Weapon()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->weaponMenuIcon);
-	}
-
-	if (HeroAt(index).HasArmor()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Armor()->Name(),
-				HeroAt(index).Armor(),
-				HeroAt(index).Armor()->HasIkari() && HeroAt(index).Armor()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->armorMenuIcon,
-				0,
-				HeroAt(index).Armor()->HasIkari() ? HeroAt(index).Armor()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->armorMenuIcon);
-	}
-
-	if (HeroAt(index).HasShield()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Shield()->Name(),
-				HeroAt(index).Shield(),
-				HeroAt(index).Shield()->HasIkari() && HeroAt(index).Shield()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->shieldMenuIcon,
-				0,
-				HeroAt(index).Shield()->HasIkari() ? HeroAt(index).Shield()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->shieldMenuIcon);
-	}
-
-	if (HeroAt(index).HasHelmet()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Helmet()->Name(),
-				HeroAt(index).Helmet(),
-				HeroAt(index).Helmet()->HasIkari() && HeroAt(index).Helmet()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->helmetMenuIcon,
-				0,
-				HeroAt(index).Helmet()->HasIkari() ? HeroAt(index).Helmet()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->helmetMenuIcon);
-	}
-
-	if (HeroAt(index).HasRing()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Ring()->Name(),
-				HeroAt(index).Ring(),
-				HeroAt(index).Ring()->HasIkari() && HeroAt(index).Ring()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->ringMenuIcon,
-				0,
-				HeroAt(index).Ring()->HasIkari() ? HeroAt(index).Ring()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->ringMenuIcon);
-	}
-
-	if (HeroAt(index).HasJewel()) {
-		ikariMenus[index].Add(
-				HeroAt(index).Jewel()->Name(),
-				HeroAt(index).Jewel(),
-				HeroAt(index).Jewel()->HasIkari() && HeroAt(index).Jewel()->GetIkari()->Cost() <= HeroAt(index).IP(),
-				res->jewelMenuIcon,
-				0,
-				HeroAt(index).Jewel()->HasIkari() ? HeroAt(index).Jewel()->GetIkari()->Name() : "");
-	} else {
-		ikariMenus[index].Add(res->noEquipmentText, 0, false, res->jewelMenuIcon);
-	}
+	ClearAllAttacks();
 }
 
 void BattleState::LoadInventory() {
-	const Inventory &inv(*res->inventory);
+	const Inventory &inv(game->state->inventory);
 	itemMenu.Clear();
 	itemMenu.Reserve(inv.MaxItems());
 	for (int i(0); i < inv.MaxItems(); ++i) {
@@ -200,34 +121,30 @@ void BattleState::LoadInventory() {
 			itemMenu.AddEmptyEntry();
 		}
 	}
-	ClearAllAttacks();
 }
 
-void BattleState::ExitState(Application &ctrl, SDL_Surface *screen) {
+void BattleState::OnExitState(SDL_Surface *screen) {
 
 }
 
-void BattleState::ResumeState(Application &ctrl, SDL_Surface *screen) {
-	// TODO: check for victory or defeat
+void BattleState::OnResumeState(SDL_Surface *screen) {
 	if (ranAway) {
-		ctrl.PopState(); // quit the battle scene
+		Ctrl().PopState(); // quit the battle scene
 		return;
 	}
 	if (Victory()) {
-		// TODO: push victory state
-		ctrl.PopState();
+		Ctrl().PopState();
 		return;
 	}
 	if (Defeat()) {
-		// TODO: push defeat state
-		ctrl.PopState();
+		Ctrl().PopState();
 		return;
 	}
 	// TODO: this should not push a state while quitting
 	if (AttackSelectionDone()) {
-		ctrl.PushState(new PerformAttacks(this));
+		Ctrl().PushState(new PerformAttacks(this));
 	} else {
-		ctrl.PushState(new SelectMoveAction(this));
+		Ctrl().PushState(new SelectMoveAction(this));
 	}
 }
 
@@ -245,7 +162,7 @@ bool BattleState::Defeat() const {
 	return true;
 }
 
-void BattleState::PauseState(Application &ctrl, SDL_Surface *screen) {
+void BattleState::OnPauseState(SDL_Surface *screen) {
 
 }
 
@@ -254,8 +171,8 @@ class OrderCompare {
 	public:
 		OrderCompare(BattleState *battle) : battle(battle) { }
 		bool operator ()(const BattleState::Order &lhs, const BattleState::Order &rhs) {
-			int lagl(lhs.isMonster ? battle->MonsterAt(lhs.index).Agility() : battle->HeroAt(lhs.index).Agility());
-			int ragl(rhs.isMonster ? battle->MonsterAt(rhs.index).Agility() : battle->HeroAt(rhs.index).Agility());
+			int lagl(lhs.isMonster ? battle->MonsterAt(lhs.index).GetStats().Agility() : battle->HeroAt(lhs.index).GetStats().Agility());
+			int ragl(rhs.isMonster ? battle->MonsterAt(rhs.index).GetStats().Agility() : battle->HeroAt(rhs.index).GetStats().Agility());
 			return lagl > ragl;
 		}
 	private:
@@ -264,18 +181,21 @@ class OrderCompare {
 
 void BattleState::CalculateAttackOrder() {
 	attackOrder.reserve(monsters.size() + NumHeroes());
-	for (int i(0); i < numHeroes; ++i) {
+	for (int i(0); i < NumHeroes(); ++i) {
 		attackOrder.push_back(Order(i, false));
 	}
 	for (vector<Monster>::size_type i(0), end(monsters.size()); i < end; ++i) {
 		attackOrder.push_back(Order(i, true));
+		MonsterAt(i).GetAttackChoice() = AttackChoice(this);
 	}
 	std::sort(attackOrder.begin(), attackOrder.end(), OrderCompare(this));
-
-	monsterAttacks.resize(monsters.size(), AttackChoice(this));
 }
 
 void BattleState::NextAttack() {
+	if (Victory() || Defeat()) {
+		attackCursor = attackOrder.size();
+		return;
+	}
 	++attackCursor;
 	while (attackCursor < int(attackOrder.size())) {
 		if (attackOrder[attackCursor].isMonster) {
@@ -287,83 +207,138 @@ void BattleState::NextAttack() {
 	}
 }
 
+bool BattleState::AttacksFinished() const {
+	return attackCursor >= int(attackOrder.size())
+			|| Victory() || Defeat();
+}
+
 void BattleState::CalculateDamage() {
 	if (CurrentAttack().isMonster) {
-		// TODO: run monster's attack script
-		monsterAttacks[CurrentAttack().index].SetType(AttackChoice::SWORD);
-		monsterAttacks[CurrentAttack().index].Selection().SelectSingle();
-		monsterAttacks[CurrentAttack().index].Selection().SelectHeroes();
-		monsterAttacks[CurrentAttack().index].Selection().SetBad(0, 15);
+		DecideMonsterAttack(MonsterAt(CurrentAttack().index));
+	}
+	AttackChoice &ac(CurrentAttack().isMonster ? MonsterAt(CurrentAttack().index).GetAttackChoice() : HeroAt(CurrentAttack().index).GetAttackChoice());
+	if (ac.GetType() == AttackChoice::DEFEND) return;
+	TargetSelection &ts(ac.Selection());
+
+	if (CurrentAttack().isMonster) {
+		const Stats &attackerStats(MonsterAt(CurrentAttack().index).GetStats());
+		CalculateDamage(attackerStats, ts);
 	} else {
-		TargetSelection &ts(AttackChoiceAt(CurrentAttack().index).Selection());
-		bool hitSome(false);
-		if (ts.TargetsEnemies()) {
-			for (int i(0); i < MaxMonsters(); ++i) {
-				if (ts.IsSelected(i)) {
-					if (MonsterAt(i).Health() > 0) {
-						ts.SetBad(i, 15);
-						hitSome = true;
-					} else {
-						ts.Unselect(i);
-					}
-				}
-			}
-			if (hitSome) return;
-			for (int i(0); i < MaxMonsters(); ++i) {
+		const Stats &attackerStats(HeroAt(CurrentAttack().index).GetStats());
+		CalculateDamage(attackerStats, ts);
+	}
+}
+
+void BattleState::DecideMonsterAttack(Monster &m) const {
+	AttackChoice &ac(m.GetAttackChoice());
+	TargetSelection &ts(ac.Selection());
+	ac.Reset();
+	int target(rand() % NumHeroes());
+	while (!HeroPositionOccupied(target)) {
+		target = rand() % NumHeroes();
+	}
+	ac.SetType(AttackChoice::SWORD);
+	ts.SelectHeroes();
+	ts.SetSingle();
+	ts.Select(target);
+}
+
+void BattleState::CalculateDamage(const Stats &attackerStats, TargetSelection &ts) const {
+	bool hitSome(false);
+	if (ts.TargetsMonsters()) {
+		for (int i(0); i < MaxMonsters(); ++i) {
+			if (ts.IsSelected(i)) {
 				if (MonsterAt(i).Health() > 0) {
-					ts.SetBad(i, 15);
-					break;
+					const Stats &defenderStats(MonsterAt(i).GetStats());
+					Uint16 damage(CalculateDamage(attackerStats, defenderStats));
+					ts.SetBad(i, damage);
+					hitSome = true;
+				} else {
+					ts.Unselect(i);
 				}
 			}
-		} else {
-			for (int i(0); i < NumHeroes(); ++i) {
-				if (ts.IsSelected(i)) {
-					if (HeroAt(i).Health() > 0) {
-						ts.SetBad(i, 15);
-						hitSome = true;
-					} else {
-						ts.Unselect(i);
-					}
-				}
+		}
+		if (hitSome) return;
+		for (int i(0); i < MaxMonsters(); ++i) {
+			if (MonsterAt(i).Health() > 0) {
+				const Stats &defenderStats(MonsterAt(i).GetStats());
+				Uint16 damage(CalculateDamage(attackerStats, defenderStats));
+				ts.SetBad(i, damage);
+				break;
 			}
-			if (hitSome) return;
-			for (int i(0); i < NumHeroes(); ++i) {
+		}
+	} else {
+		for (int i(0); i < NumHeroes(); ++i) {
+			if (ts.IsSelected(i)) {
 				if (HeroAt(i).Health() > 0) {
-					ts.SetBad(i, 15);
-					break;
+					const Stats &defenderStats(HeroAt(i).GetStats());
+					Uint16 damage(CalculateDamage(attackerStats, defenderStats));
+					ts.SetBad(i, damage);
+					hitSome = true;
+				} else {
+					ts.Unselect(i);
 				}
 			}
 		}
+		if (hitSome) return;
+		for (int i(0); i < NumHeroes(); ++i) {
+			if (HeroAt(i).Health() > 0) {
+				const Stats &defenderStats(HeroAt(i).GetStats());
+				Uint16 damage(CalculateDamage(attackerStats, defenderStats));
+				ts.SetBad(i, damage);
+				break;
+			}
+		}
 	}
 }
 
+Uint16 BattleState::CalculateDamage(const Stats &attacker, const Stats &defender) const {
+	return attacker.Attack() / 2 - defender.Defense() / 4;
+}
+
 void BattleState::ApplyDamage() {
 	if (attackCursor < 0) return;
-	AttackChoice &ac(CurrentAttack().isMonster ? monsterAttacks[CurrentAttack().index] : AttackChoiceAt(CurrentAttack().index));
+	AttackChoice &ac(CurrentAttack().isMonster ? MonsterAt(CurrentAttack().index).GetAttackChoice() : HeroAt(CurrentAttack().index).GetAttackChoice());
 	TargetSelection &ts(ac.Selection());
-	if (ts.TargetsEnemies()) {
+	if (ts.TargetsMonsters()) {
 		for (int i(0); i < MaxMonsters(); ++i) {
+			Monster &monster(MonsterAt(i));
 			if (ts.IsBad(i)) {
-				MonsterAt(i).SubtractHealth(ts.GetAmount(i));
+				monster.SubtractHealth(ts.GetAmount(i));
+				if (monster.Health() == 0) {
+					expReward += monster.ExpReward();
+					goldReward += monster.GoldReward();
+				}
 			}
 		}
 	} else {
 		for (int i(0); i < NumHeroes(); ++i) {
+			Hero &hero(HeroAt(i));
 			if (ts.IsBad(i)) {
-				HeroAt(i).SubtractHealth(ts.GetAmount(i));
+				hero.SubtractHealth(ts.GetAmount(i));
 			}
 		}
 	}
 }
 
+AttackChoice &BattleState::CurrentAttackAttackChoice() {
+	if (CurrentAttack().isMonster) {
+		return MonsterAt(CurrentAttack().index).GetAttackChoice();
+	} else {
+		return HeroAt(CurrentAttack().index).GetAttackChoice();
+	}
+}
+
 void BattleState::ClearAllAttacks() {
 	attackCursor = -1;
 	activeHero = -1;
-	for (int i(0); i < numHeroes; ++i) {
-		attackChoices[i] = AttackChoice(this);
+	for (int i(0); i < NumHeroes(); ++i) {
+		HeroAt(i).GetAttackChoice() = AttackChoice(this);
+	}
+	for (int i(0); i < MaxMonsters(); ++i) {
+		MonsterAt(i).GetAttackChoice() = AttackChoice(this);
 	}
 	attackOrder.clear();
-	monsterAttacks.clear();
 }
 
 
@@ -376,12 +351,14 @@ void BattleState::UpdateWorld(float deltaT) {
 }
 
 void BattleState::Render(SDL_Surface *screen) {
+	assert(screen);
 	Vector<int> offset(CalculateScreenOffset(screen));
 	RenderBackground(screen, offset);
 	RenderMonsters(screen, offset);
 }
 
 void BattleState::RenderBackground(SDL_Surface *screen, const Vector<int> &offset) {
+	assert(screen);
 	// black for now
 	SDL_FillRect(screen, 0, SDL_MapRGB(screen->format, 0, 0, 0));
 	SDL_Rect destRect;
@@ -393,27 +370,32 @@ void BattleState::RenderBackground(SDL_Surface *screen, const Vector<int> &offse
 }
 
 void BattleState::RenderMonsters(SDL_Surface *screen, const Vector<int> &offset) {
+	assert(screen);
 	for (vector<Monster>::size_type i(0), end(monsters.size()); i < end; ++i) {
 		if (MonsterPositionOccupied(i)) {
-			monsters[i].Sprite()->DrawCenter(screen, monsterPositions[i] + offset);
+			if (monsters[i].GetAnimation().Running()) {
+				monsters[i].GetAnimation().DrawCenter(screen, monsters[i].Position() + offset);
+			} else {
+				monsters[i].Sprite()->DrawCenter(screen, monsters[i].Position() + offset);
+			}
 		}
 	}
 }
 
 void BattleState::RenderHeroes(SDL_Surface *screen, const Vector<int> &offset) {
+	assert(screen);
 	for (int i(0); i < numHeroes; ++i) {
-		if (heroes[i].AttackAnimation() && heroes[i].AttackAnimation()->Running()) {
-			heroes[i].AttackAnimation()->DrawCenter(screen, heroesPositions[i] + offset);
-		} else if (heroes[i].SpellAnimation() && heroes[i].SpellAnimation()->Running()) {
-			heroes[i].SpellAnimation()->DrawCenter(screen, heroesPositions[i] + offset);
+		if (heroes[i].GetAnimation().Running()) {
+			heroes[i].GetAnimation().DrawCenter(screen, heroes[i].Position() + offset);
 		} else {
 			int row(heroes[i].Health() > 0 ? 0 : 2);
-			heroes[i].Sprite()->DrawCenter(screen, heroesPositions[i] + offset, 1, row);
+			heroes[i].Sprite()->DrawCenter(screen, heroes[i].Position() + offset, 1, row);
 		}
 	}
 }
 
 void BattleState::RenderHeroTags(SDL_Surface *screen, const Vector<int> &offset) {
+	assert(screen);
 	int tagHeight(attackTypeMenu.Height());
 	int tagWidth(attackTypeMenu.Width() * 2 + attackTypeMenu.Width() / 2);
 
@@ -423,6 +405,7 @@ void BattleState::RenderHeroTags(SDL_Surface *screen, const Vector<int> &offset)
 }
 
 void BattleState::RenderSmallHeroTags(SDL_Surface *screen, const Vector<int> &offset) {
+	assert(screen);
 	int tagHeight(res->normalFont->CharHeight() * 4 + res->smallHeroTagFrame->BorderHeight() * 2);
 	int tagWidth(res->normalFont->CharWidth() * 6 + res->smallHeroTagFrame->BorderWidth() * 2);
 
@@ -434,7 +417,7 @@ void BattleState::RenderSmallHeroTags(SDL_Surface *screen, const Vector<int> &of
 	SDL_FillRect(screen, &rect, SDL_MapRGB(screen->format, 0, 0, 0));
 	rect.y += res->normalFont->CharHeight() / 8;
 	rect.h -= res->normalFont->CharHeight() / 4;
-	SDL_FillRect(screen, &rect, res->heroesBgColor);
+	SDL_FillRect(screen, &rect, res->heroesBgColor.MapRGB(screen->format));
 
 	for (int i(0); i < numHeroes; ++i) {
 		smallHeroTags[i].Render(screen, tagWidth, tagHeight, smallHeroTagPositions[i] + offset);