X-Git-Url: http://git.localhorst.tv/?a=blobdiff_plain;f=src%2Fchunk.cpp;h=23d5a13c260e8dfdefab8e5ec3f444a8a537967f;hb=35c09fc00094a3d390732fd533b2bd03413d90c7;hp=de30ae91a58d5e5bb092f6ed58b5831b0996bad4;hpb=fc73b44e0f90affd42cac2f944f46633a6b8364e;p=blank.git

diff --git a/src/chunk.cpp b/src/chunk.cpp
index de30ae9..23d5a13 100644
--- a/src/chunk.cpp
+++ b/src/chunk.cpp
@@ -2,6 +2,7 @@
 
 #include "generator.hpp"
 
+#include <algorithm>
 #include <limits>
 #include <queue>
 #include <glm/gtx/transform.hpp>
@@ -11,9 +12,9 @@ namespace blank {
 
 Chunk::Chunk(const BlockTypeRegistry &types)
 : types(&types)
-, neighbor{ 0, 0, 0, 0, 0, 0 }
-, blocks()
-, light()
+, neighbor{0}
+, blocks{}
+, light{0}
 , model()
 , position(0, 0, 0)
 , dirty(false) {
@@ -22,23 +23,19 @@ Chunk::Chunk(const BlockTypeRegistry &types)
 
 Chunk::Chunk(Chunk &&other)
 : types(other.types)
-, blocks(std::move(other.blocks))
-, light(std::move(other.light))
 , model(std::move(other.model))
 , position(other.position)
 , dirty(other.dirty) {
-	for (size_t i = 0; i < Block::FACE_COUNT; ++i) {
-		neighbor[i] = other.neighbor[i];
-	}
+	std::copy(other.neighbor, other.neighbor + sizeof(neighbor), neighbor);
+	std::copy(other.blocks, other.blocks + sizeof(blocks), blocks);
+	std::copy(other.light, other.light + sizeof(light), light);
 }
 
 Chunk &Chunk::operator =(Chunk &&other) {
 	types = other.types;
-	for (size_t i = 0; i < Block::FACE_COUNT; ++i) {
-		neighbor[i] = other.neighbor[i];
-	}
-	blocks = std::move(other.blocks);
-	light = std::move(other.light);
+	std::copy(other.neighbor, other.neighbor + sizeof(neighbor), neighbor);
+	std::copy(other.blocks, other.blocks + sizeof(blocks), blocks);
+	std::copy(other.light, other.light + sizeof(light), light);
 	model = std::move(other.model);
 	position = other.position;
 	dirty = other.dirty;
@@ -46,77 +43,6 @@ Chunk &Chunk::operator =(Chunk &&other) {
 }
 
 
-void Chunk::SetNeighbor(Chunk &other) {
-	if (other.position == position + Pos(-1, 0, 0)) {
-		neighbor[Block::FACE_LEFT] = &other;
-		other.neighbor[Block::FACE_RIGHT] = this;
-	} else if (other.position == position + Pos(1, 0, 0)) {
-		neighbor[Block::FACE_RIGHT] = &other;
-		other.neighbor[Block::FACE_LEFT] = this;
-	} else if (other.position == position + Pos(0, -1, 0)) {
-		neighbor[Block::FACE_DOWN] = &other;
-		other.neighbor[Block::FACE_UP] = this;
-	} else if (other.position == position + Pos(0, 1, 0)) {
-		neighbor[Block::FACE_UP] = &other;
-		other.neighbor[Block::FACE_DOWN] = this;
-	} else if (other.position == position + Pos(0, 0, -1)) {
-		neighbor[Block::FACE_BACK] = &other;
-		other.neighbor[Block::FACE_FRONT] = this;
-	} else if (other.position == position + Pos(0, 0, 1)) {
-		neighbor[Block::FACE_FRONT] = &other;
-		other.neighbor[Block::FACE_BACK] = this;
-	}
-}
-
-void Chunk::ClearNeighbors() {
-	for (int i = 0; i < Block::FACE_COUNT; ++i) {
-		neighbor[i] = nullptr;
-	}
-}
-
-void Chunk::Unlink() {
-	if (neighbor[Block::FACE_UP]) {
-		neighbor[Block::FACE_UP]->neighbor[Block::FACE_DOWN] = nullptr;
-	}
-	if (neighbor[Block::FACE_DOWN]) {
-		neighbor[Block::FACE_DOWN]->neighbor[Block::FACE_UP] = nullptr;
-	}
-	if (neighbor[Block::FACE_LEFT]) {
-		neighbor[Block::FACE_LEFT]->neighbor[Block::FACE_RIGHT] = nullptr;
-	}
-	if (neighbor[Block::FACE_RIGHT]) {
-		neighbor[Block::FACE_RIGHT]->neighbor[Block::FACE_LEFT] = nullptr;
-	}
-	if (neighbor[Block::FACE_FRONT]) {
-		neighbor[Block::FACE_FRONT]->neighbor[Block::FACE_BACK] = nullptr;
-	}
-	if (neighbor[Block::FACE_BACK]) {
-		neighbor[Block::FACE_BACK]->neighbor[Block::FACE_FRONT] = nullptr;
-	}
-}
-
-void Chunk::Relink() {
-	if (neighbor[Block::FACE_UP]) {
-		neighbor[Block::FACE_UP]->neighbor[Block::FACE_DOWN] = this;
-	}
-	if (neighbor[Block::FACE_DOWN]) {
-		neighbor[Block::FACE_DOWN]->neighbor[Block::FACE_UP] = this;
-	}
-	if (neighbor[Block::FACE_LEFT]) {
-		neighbor[Block::FACE_LEFT]->neighbor[Block::FACE_RIGHT] = this;
-	}
-	if (neighbor[Block::FACE_RIGHT]) {
-		neighbor[Block::FACE_RIGHT]->neighbor[Block::FACE_LEFT] = this;
-	}
-	if (neighbor[Block::FACE_FRONT]) {
-		neighbor[Block::FACE_FRONT]->neighbor[Block::FACE_BACK] = this;
-	}
-	if (neighbor[Block::FACE_BACK]) {
-		neighbor[Block::FACE_BACK]->neighbor[Block::FACE_FRONT] = this;
-	}
-}
-
-
 namespace {
 
 struct SetNode {
@@ -131,16 +57,12 @@ struct SetNode {
 	void Set(int level) { chunk->SetLight(pos, level); }
 
 	bool HasNext(Block::Face face) {
-		const Block *next = chunk->FindNext(pos, face);
-		return next && !chunk->Type(*next).block_light;
+		const BlockLookup next(chunk, pos, face);
+		return next && !next.GetType().block_light;
 	}
 	SetNode GetNext(Block::Face face) {
-		Chunk::Pos next_pos(pos + Block::FaceNormal(face));
-		if (Chunk::InBounds(next_pos)) {
-			return SetNode(chunk, next_pos);
-		} else {
-			return SetNode(&chunk->GetNeighbor(face), next_pos - (Block::FaceNormal(face) * Chunk::Extent()));
-		}
+		const BlockLookup next(chunk, pos, face);
+		return SetNode(&next.GetChunk(), next.GetBlockPos());
 	}
 
 };
@@ -156,6 +78,11 @@ struct UnsetNode
 	UnsetNode(const SetNode &set)
 	: SetNode(set), level(Get()) { }
 
+
+	bool HasNext(Block::Face face) {
+		const BlockLookup next(chunk, pos, face);
+		return next;
+	}
 	UnsetNode GetNext(Block::Face face) { return UnsetNode(SetNode::GetNext(face)); }
 
 };
@@ -226,26 +153,19 @@ void Chunk::SetBlock(int index, const Block &block) {
 		work_light();
 	} else if (new_type.block_light && !old_type.block_light) {
 		// obstacle added
-		dark_queue.emplace(this, ToPos(index));
-		SetLight(index, 0);
-		work_dark();
-		work_light();
+		if (GetLight(index) > 0) {
+			dark_queue.emplace(this, ToPos(index));
+			SetLight(index, 0);
+			work_dark();
+			work_light();
+		}
 	} else if (!new_type.block_light && old_type.block_light) {
 		// obstacle removed
 		int level = 0;
 		for (int face = 0; face < Block::FACE_COUNT; ++face) {
-			Pos next_pos(ToPos(index) + Block::FaceNormal(Block::Face(face)));
-			int next_level = 0;
-			if (InBounds(next_pos)) {
-				next_level = GetLight(next_pos);
-			} else {
-				if (HasNeighbor(Block::Face(face))) {
-					next_pos -= (Block::FaceNormal(Block::Face(face)) * Chunk::Extent());
-					next_level = GetNeighbor(Block::Face(face)).GetLight(next_pos);
-				}
-			}
-			if (level < next_level) {
-				level = next_level;
+			BlockLookup next_block(this, ToPos(index), Block::Face(face));
+			if (next_block) {
+				level = std::min(level, next_block.GetLight());
 			}
 		}
 		if (level > 1) {
@@ -256,26 +176,178 @@ void Chunk::SetBlock(int index, const Block &block) {
 	}
 }
 
-const Block *Chunk::FindNext(const Pos &pos, Block::Face face) const {
-	Pos next_pos(pos + Block::FaceNormal(face));
-	if (InBounds(next_pos)) {
-		return &BlockAt(pos + Block::FaceNormal(face));
-	} else if (HasNeighbor(face)) {
-		return &GetNeighbor(face).BlockAt(next_pos - (Block::FaceNormal(face) * Extent()));
-	} else {
-		return nullptr;
+void Chunk::SetNeighbor(Chunk &other) {
+	if (other.position == position + Pos(-1, 0, 0)) {
+		if (neighbor[Block::FACE_LEFT] != &other) {
+			neighbor[Block::FACE_LEFT] = &other;
+			other.neighbor[Block::FACE_RIGHT] = this;
+			for (int z = 0; z < Depth(); ++z) {
+				for (int y = 0; y < Height(); ++y) {
+					Pos my_pos(0, y, z);
+					Pos other_pos(Width() - 1, y, z);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	} else if (other.position == position + Pos(1, 0, 0)) {
+		if (neighbor[Block::FACE_RIGHT] != &other) {
+			neighbor[Block::FACE_RIGHT] = &other;
+			other.neighbor[Block::FACE_LEFT] = this;
+			for (int z = 0; z < Depth(); ++z) {
+				for (int y = 0; y < Height(); ++y) {
+					Pos my_pos(Width() - 1, y, z);
+					Pos other_pos(0, y, z);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	} else if (other.position == position + Pos(0, -1, 0)) {
+		if (neighbor[Block::FACE_DOWN] != &other) {
+			neighbor[Block::FACE_DOWN] = &other;
+			other.neighbor[Block::FACE_UP] = this;
+			for (int z = 0; z < Depth(); ++z) {
+				for (int x = 0; x < Width(); ++x) {
+					Pos my_pos(x, 0, z);
+					Pos other_pos(x, Height() - 1, z);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	} else if (other.position == position + Pos(0, 1, 0)) {
+		if (neighbor[Block::FACE_UP] != &other) {
+			neighbor[Block::FACE_UP] = &other;
+			other.neighbor[Block::FACE_DOWN] = this;
+			for (int z = 0; z < Depth(); ++z) {
+				for (int x = 0; x < Width(); ++x) {
+					Pos my_pos(x, Height() - 1, z);
+					Pos other_pos(x, 0, z);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	} else if (other.position == position + Pos(0, 0, -1)) {
+		if (neighbor[Block::FACE_BACK] != &other) {
+			neighbor[Block::FACE_BACK] = &other;
+			other.neighbor[Block::FACE_FRONT] = this;
+			for (int y = 0; y < Height(); ++y) {
+				for (int x = 0; x < Width(); ++x) {
+					Pos my_pos(x, y, 0);
+					Pos other_pos(x, y, Depth() - 1);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	} else if (other.position == position + Pos(0, 0, 1)) {
+		if (neighbor[Block::FACE_FRONT] != &other) {
+			neighbor[Block::FACE_FRONT] = &other;
+			other.neighbor[Block::FACE_BACK] = this;
+			for (int y = 0; y < Height(); ++y) {
+				for (int x = 0; x < Width(); ++x) {
+					Pos my_pos(x, y, Depth() - 1);
+					Pos other_pos(x, y, 0);
+					if (GetLight(my_pos) > 0) {
+						light_queue.emplace(this, my_pos);
+					}
+					if (other.GetLight(other_pos) > 0) {
+						light_queue.emplace(&other, other_pos);
+					}
+				}
+			}
+			work_light();
+		}
+	}
+}
+
+void Chunk::ClearNeighbors() {
+	for (int i = 0; i < Block::FACE_COUNT; ++i) {
+		neighbor[i] = nullptr;
+	}
+}
+
+void Chunk::Unlink() {
+	for (int face = 0; face < Block::FACE_COUNT; ++face) {
+		if (neighbor[face]) {
+			neighbor[face]->neighbor[Block::Opposite(Block::Face(face))] = nullptr;
+		}
+	}
+}
+
+void Chunk::Relink() {
+	for (int face = 0; face < Block::FACE_COUNT; ++face) {
+		if (neighbor[face]) {
+			neighbor[face]->neighbor[Block::Opposite(Block::Face(face))] = this;
+		}
 	}
 }
 
 
 void Chunk::SetLight(int index, int level) {
-	light[index] = level;
+	if (light[index] != level) {
+		light[index] = level;
+		Invalidate();
+	}
 }
 
 int Chunk::GetLight(int index) const {
 	return light[index];
 }
 
+float Chunk::GetVertexLight(int index, const BlockModel::Position &vtx, const Model::Normal &norm) const {
+	float light = GetLight(index);
+	Chunk::Pos pos(ToPos(index));
+
+	Block::Face direct_face(Block::NormalFace(norm));
+	// tis okay
+	BlockLookup direct(const_cast<Chunk *>(this), pos, Block::NormalFace(norm));
+	if (direct) {
+		float direct_light = direct.GetLight();
+		if (direct_light > light) {
+			light = direct_light;
+		}
+	}
+
+	// cheap alternative until AO etc are implemented
+	// to tell the faces apart
+
+	if (direct_face == Block::FACE_LEFT || direct_face == Block::FACE_RIGHT) {
+		light -= 0.2;
+	} else if (direct_face == Block::FACE_FRONT || direct_face == Block::FACE_BACK) {
+		light -= 0.4;
+	}
+
+	return light;
+}
+
 
 bool Chunk::IsSurface(const Pos &pos) const {
 	const Block &block = BlockAt(pos);
@@ -283,8 +355,8 @@ bool Chunk::IsSurface(const Pos &pos) const {
 		return false;
 	}
 	for (int face = 0; face < Block::FACE_COUNT; ++face) {
-		const Block *next = FindNext(pos, Block::Face(face));
-		if (!next || !Type(*next).visible) {
+		BlockLookup next = BlockLookup(const_cast<Chunk *>(this), pos, Block::Face(face));
+		if (!next || !next.GetType().visible) {
 			return true;
 		}
 	}
@@ -292,12 +364,6 @@ bool Chunk::IsSurface(const Pos &pos) const {
 }
 
 
-void Chunk::Allocate() {
-	blocks.resize(Size(), Block(0));
-	light.resize(Size(), 0);
-}
-
-
 void Chunk::Draw() {
 	if (dirty) {
 		Update();
@@ -355,7 +421,7 @@ glm::mat4 Chunk::Transform(const Pos &offset) const {
 
 namespace {
 
-Model::Buffer buf;
+BlockModel::Buffer buf;
 
 }
 
@@ -375,112 +441,114 @@ void Chunk::Update() {
 	buf.Clear();
 	buf.Reserve(vtx_count, idx_count);
 
-	Model::Index vtx_counter = 0;
+	BlockModel::Index vtx_counter = 0;
 	for (size_t i = 0; i < Size(); ++i) {
 		const BlockType &type = Type(blocks[i]);
 
-		if (!type.visible || Obstructed(i)) continue;
+		if (!type.visible || Obstructed(i).All()) continue;
 
-		type.FillModel(buf, ToTransform(i), vtx_counter);
+		type.FillBlockModel(buf, ToTransform(i), vtx_counter);
+		size_t vtx_begin = vtx_counter;
 		vtx_counter += type.shape->VertexCount();
+
+		for (size_t vtx = vtx_begin; vtx < vtx_counter; ++vtx) {
+			buf.lights.emplace_back(GetVertexLight(
+				i,
+				buf.vertices[vtx],
+				type.shape->VertexNormal(vtx - vtx_begin, blocks[i].Transform())
+			));
+		}
 	}
 
 	model.Update(buf);
 	dirty = false;
 }
 
-bool Chunk::Obstructed(int idx) const {
+Block::FaceSet Chunk::Obstructed(int idx) const {
 	Chunk::Pos pos(ToPos(idx));
+	Block::FaceSet result;
 
-	Chunk::Pos left_pos(pos + Chunk::Pos(-1, 0, 0));
-	const Block *left_block = nullptr;
-	if (InBounds(left_pos)) {
-		left_block = &BlockAt(left_pos);
-	} else if (HasNeighbor(Block::FACE_LEFT)) {
-		left_pos += Chunk::Pos(Width(), 0, 0);
-		left_block = &GetNeighbor(Block::FACE_LEFT).BlockAt(left_pos);
-	} else {
-		return false;
-	}
-	if (!Type(*left_block).FaceFilled(*left_block, Block::FACE_RIGHT)) {
-		return false;
+	for (int f = 0; f < Block::FACE_COUNT; ++f) {
+		Block::Face face = Block::Face(f);
+		BlockLookup next(const_cast<Chunk *>(this), pos, face);
+		if (next && next.GetType().FaceFilled(next.GetBlock(), Block::Opposite(face))) {
+			result.Set(face);
+		}
 	}
 
-	Chunk::Pos right_pos(pos + Chunk::Pos(1, 0, 0));
-	const Block *right_block = nullptr;
-	if (InBounds(right_pos)) {
-		right_block = &BlockAt(right_pos);
-	} else if (HasNeighbor(Block::FACE_RIGHT)) {
-		right_pos += Chunk::Pos(-Width(), 0, 0);
-		right_block = &GetNeighbor(Block::FACE_RIGHT).BlockAt(right_pos);
-	} else {
-		return false;
-	}
-	if (!Type(*right_block).FaceFilled(*right_block, Block::FACE_LEFT)) {
-		return false;
-	}
+	return result;
+}
 
-	Chunk::Pos down_pos(pos + Chunk::Pos(0, -1, 0));
-	const Block *down_block = nullptr;
-	if (InBounds(down_pos)) {
-		down_block = &BlockAt(down_pos);
-	} else if (HasNeighbor(Block::FACE_DOWN)) {
-		down_pos += Chunk::Pos(0, Height(), 0);
-		down_block = &GetNeighbor(Block::FACE_DOWN).BlockAt(down_pos);
-	} else {
-		return false;
-	}
-	if (!Type(*down_block).FaceFilled(*down_block, Block::FACE_UP)) {
-		return false;
-	}
+glm::mat4 Chunk::ToTransform(int idx) const {
+	return glm::translate(glm::mat4(1.0f), ToCoords(idx)) * blocks[idx].Transform();
+}
 
-	Chunk::Pos up_pos(pos + Chunk::Pos(0, 1, 0));
-	const Block *up_block = nullptr;
-	if (InBounds(up_pos)) {
-		up_block = &BlockAt(up_pos);
-	} else if (HasNeighbor(Block::FACE_UP)) {
-		up_pos += Chunk::Pos(0, -Height(), 0);
-		up_block = &GetNeighbor(Block::FACE_UP).BlockAt(up_pos);
-	} else {
-		return false;
+
+BlockLookup::BlockLookup(Chunk *c, const Chunk::Pos &p)
+: chunk(c), pos(p) {
+	while (pos.x >= Chunk::Width()) {
+		if (chunk->HasNeighbor(Block::FACE_RIGHT)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_RIGHT);
+			pos.x -= Chunk::Width();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-	if (!Type(*up_block).FaceFilled(*up_block, Block::FACE_DOWN)) {
-		return false;
+	while (pos.x < 0) {
+		if (chunk->HasNeighbor(Block::FACE_LEFT)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_LEFT);
+			pos.x += Chunk::Width();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-
-	Chunk::Pos back_pos(pos + Chunk::Pos(0, 0, -1));
-	const Block *back_block = nullptr;
-	if (InBounds(back_pos)) {
-		back_block = &BlockAt(back_pos);
-	} else if (HasNeighbor(Block::FACE_BACK)) {
-		back_pos += Chunk::Pos(0, 0, Depth());
-		back_block = &GetNeighbor(Block::FACE_BACK).BlockAt(back_pos);
-	} else {
-		return false;
+	while (pos.y >= Chunk::Height()) {
+		if (chunk->HasNeighbor(Block::FACE_UP)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_UP);
+			pos.y -= Chunk::Height();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-	if (!Type(*back_block).FaceFilled(*back_block, Block::FACE_FRONT)) {
-		return false;
+	while (pos.y < 0) {
+		if (chunk->HasNeighbor(Block::FACE_DOWN)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_DOWN);
+			pos.y += Chunk::Height();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-
-	Chunk::Pos front_pos(pos + Chunk::Pos(0, 0, 1));
-	const Block *front_block = nullptr;
-	if (InBounds(front_pos)) {
-		front_block = &BlockAt(front_pos);
-	} else if (HasNeighbor(Block::FACE_FRONT)) {
-		front_pos += Chunk::Pos(0, 0, -Depth());
-		front_block = &GetNeighbor(Block::FACE_FRONT).BlockAt(front_pos);
-	} else {
-		return false;
+	while (pos.z >= Chunk::Depth()) {
+		if (chunk->HasNeighbor(Block::FACE_FRONT)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_FRONT);
+			pos.z -= Chunk::Depth();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-	if (!Type(*front_block).FaceFilled(*front_block, Block::FACE_BACK)) {
-		return false;
+	while (pos.z < 0) {
+		if (chunk->HasNeighbor(Block::FACE_BACK)) {
+			chunk = &chunk->GetNeighbor(Block::FACE_BACK);
+			pos.z += Chunk::Depth();
+		} else {
+			chunk = nullptr;
+			return;
+		}
 	}
-
-	return true;
 }
 
-glm::mat4 Chunk::ToTransform(int idx) const {
-	return glm::translate(glm::mat4(1.0f), ToCoords(idx)) * blocks[idx].Transform();
+BlockLookup::BlockLookup(Chunk *c, const Chunk::Pos &p, Block::Face face)
+: chunk(c), pos(p) {
+	pos += Block::FaceNormal(face);
+	if (!Chunk::InBounds(pos)) {
+		pos -= Block::FaceNormal(face) * Chunk::Extent();
+		chunk = &chunk->GetNeighbor(face);
+	}
 }
 
 
@@ -527,6 +595,42 @@ void ChunkLoader::Generate(const Chunk::Pos &from, const Chunk::Pos &to) {
 				} else if (pos == base) {
 					Generate(pos);
 
+				//	light testing
+				//	for (int i = 0; i < 16; ++i) {
+				//		for (int j = 0; j < 16; ++j) {
+				//			loaded.back().SetBlock(Chunk::Pos{  i, j,  0 }, Block(1));
+				//			loaded.back().SetBlock(Chunk::Pos{  i, j, 15 }, Block(1));
+				//			loaded.back().SetBlock(Chunk::Pos{  0, j,  i }, Block(1));
+				//			loaded.back().SetBlock(Chunk::Pos{ 15, j,  i }, Block(1));
+				//		}
+				//	}
+				//	loaded.back().SetBlock(Chunk::Pos{  1,  0,  1 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 14,  0,  1 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  1,  0, 14 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 14,  0, 14 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  1, 15,  1 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 14, 15,  1 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  1, 15, 14 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 14, 15, 14 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  7,  7,  0 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  8,  7,  0 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  7,  8,  0 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  8,  8,  0 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  7,  7, 15 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  8,  7, 15 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  7,  8, 15 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  8,  8, 15 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  0,  7,  7 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  0,  7,  8 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  0,  8,  7 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{  0,  8,  8 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 15,  7,  7 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 15,  7,  8 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 15,  8,  7 }, Block(13));
+				//	loaded.back().SetBlock(Chunk::Pos{ 15,  8,  8 }, Block(13));
+				//	loaded.back().Invalidate();
+				//	loaded.back().CheckUpdate();
+
 				//	orientation testing
 				//	for (int i = 0; i < Block::FACE_COUNT; ++i) {
 				//		for (int j = 0; j < Block::TURN_COUNT; ++j) {
@@ -548,8 +652,8 @@ Chunk &ChunkLoader::Generate(const Chunk::Pos &pos) {
 	loaded.emplace_back(reg);
 	Chunk &chunk = loaded.back();
 	chunk.Position(pos);
-	Insert(chunk);
 	gen(chunk);
+	Insert(chunk);
 	return chunk;
 }
 
@@ -641,38 +745,31 @@ void ChunkLoader::GenerateSurrounding(const Chunk::Pos &pos) {
 }
 
 void ChunkLoader::Update() {
-	bool reused = false;
-	if (!to_generate.empty()) {
-		Chunk::Pos pos(to_generate.front());
-
-		for (auto iter(to_free.begin()), end(to_free.end()); iter != end; ++iter) {
-			if (iter->Position() == pos) {
-				iter->Relink();
-				loaded.splice(loaded.end(), to_free, iter);
-				reused = true;
-				break;
-			}
-		}
+	if (to_generate.empty()) {
+		return;
+	}
 
-		if (!reused) {
-			if (to_free.empty()) {
-				loaded.emplace_back(reg);
-			} else {
-				to_free.front().ClearNeighbors();
-				loaded.splice(loaded.end(), to_free, to_free.begin());
-				reused = true;
-			}
-			Chunk &chunk = loaded.back();
-			chunk.Position(pos);
-			Insert(chunk);
-			gen(chunk);
+	Chunk::Pos pos(to_generate.front());
+	to_generate.pop_front();
+
+	for (auto iter(to_free.begin()), end(to_free.end()); iter != end; ++iter) {
+		if (iter->Position() == pos) {
+			iter->Relink();
+			loaded.splice(loaded.end(), to_free, iter);
+			return;
 		}
-		to_generate.pop_front();
 	}
 
-	if (!reused && !to_free.empty()) {
-		to_free.pop_front();
+	if (to_free.empty()) {
+		loaded.emplace_back(reg);
+	} else {
+		to_free.front().ClearNeighbors();
+		loaded.splice(loaded.end(), to_free, to_free.begin());
 	}
+	Chunk &chunk = loaded.back();
+	chunk.Position(pos);
+	gen(chunk);
+	Insert(chunk);
 }
 
 }