some linting

diff --git a/src/app/Assets.hpp b/src/app/Assets.hpp
index ef63518ae270834ebc8d7862ad20471543eacb68..9766577c565dd0d11b9ce4f0c98db3bbae1094d4 100644 (file)
--- a/src/app/Assets.hpp
+++ b/src/app/Assets.hpp
@@ -54,7 +54,7 @@ struct Assets {
        Font large_ui_font;
        Font small_ui_font;
 
-       Assets(const AssetLoader &);
+       explicit Assets(const AssetLoader &);
 
 };
 

diff --git a/src/geometry/primitive.hpp b/src/geometry/primitive.hpp
index 76064c1b13f8ce2e26ef26075e3e44b8dce9c750..52a3617835245382b6e2014091116cc881fc3c87 100644 (file)
--- a/src/geometry/primitive.hpp
+++ b/src/geometry/primitive.hpp
@@ -102,7 +102,7 @@ struct Plane {
 
        Plane(const glm::vec3 &n, float d)
        : normal(n), dist(d) { }
-       Plane(const glm::vec4 &abcd)
+       explicit Plane(const glm::vec4 &abcd)
        : normal(abcd), dist(abcd.w) { }
 
        void Normalize() noexcept {
@@ -130,14 +130,14 @@ struct Frustum {
        const Plane &Far() const noexcept { return plane[5]; }
 
        /// create frustum from transposed MVP
-       Frustum(const glm::mat4 &mat)
+       explicit Frustum(const glm::mat4 &mat)
        : plane{
-               { mat[3] + mat[0] },
-               { mat[3] - mat[0] },
-               { mat[3] + mat[1] },
-               { mat[3] - mat[1] },
-               { mat[3] + mat[2] },
-               { mat[3] - mat[2] },
+               Plane{ mat[3] + mat[0] },
+               Plane{ mat[3] - mat[0] },
+               Plane{ mat[3] + mat[1] },
+               Plane{ mat[3] - mat[1] },
+               Plane{ mat[3] + mat[2] },
+               Plane{ mat[3] - mat[2] },
        } { }
 
        void Normalize() noexcept {

diff --git a/src/io/TokenStreamReader.hpp b/src/io/TokenStreamReader.hpp
index 7b5a8ff74da6aeb54ceefe9a139b09062df2fd63..f1b73491447c5c662aa37b219b2e42b0d5c283db 100644 (file)
--- a/src/io/TokenStreamReader.hpp
+++ b/src/io/TokenStreamReader.hpp
@@ -14,7 +14,7 @@ namespace blank {
 class TokenStreamReader {
 
 public:
-       TokenStreamReader(std::istream &);
+       explicit TokenStreamReader(std::istream &);
 
        bool HasMore();
        const Token &Next();

diff --git a/src/model/bounds.hpp b/src/model/bounds.hpp
index 7177290521bb258311b3763e765c73e9aac8e05c..72ea01f506699c19e5e42fbfb0e351324d7a9601 100644 (file)
--- a/src/model/bounds.hpp
+++ b/src/model/bounds.hpp
@@ -14,7 +14,7 @@ class CuboidBounds
 : public CollisionBounds {
 
 public:
-       CuboidBounds(const AABB &bounds);
+       explicit CuboidBounds(const AABB &bounds);
 
        bool Intersects(const Ray &, const glm::mat4 &, float &, glm::vec3 &) const noexcept override;
        bool Intersects(const glm::mat4 &, const AABB &, const glm::mat4 &, float &, glm::vec3 &) const noexcept override;

diff --git a/src/world/ChunkStore.hpp b/src/world/ChunkStore.hpp
index 79a9db1d1373ccb859705a06acf3deb4d115d201..a0fd0f93686b07b68a934160c658cc4390828e76 100644 (file)
--- a/src/world/ChunkStore.hpp
+++ b/src/world/ChunkStore.hpp
@@ -13,7 +13,7 @@ class ChunkIndex;
 class ChunkStore {
 
 public:
-       ChunkStore(const BlockTypeRegistry &);
+       explicit ChunkStore(const BlockTypeRegistry &);
        ~ChunkStore();
 
        ChunkStore(const ChunkStore &) = delete;

diff --git a/src/world/chunk.cpp b/src/world/chunk.cpp
index 3374e996f74bfae6c9a3c1a36d0d9b972ce69f7b..7f2233e2def66a6e99dee791d6d2e0ce1a73b0ad 100644 (file)
--- a/src/world/chunk.cpp
+++ b/src/world/chunk.cpp
@@ -113,7 +113,7 @@ struct UnsetNode
        UnsetNode(Chunk *chunk, RoughLocation::Fine pos)
        : SetNode(chunk, pos), level(Get()) { }
 
-       UnsetNode(const SetNode &set)
+       explicit UnsetNode(const SetNode &set)
        : SetNode(set), level(Get()) { }