removed redundant BattleState::ActiveHeroAttackChoice()

[l2e.git] / src / battle / states / SelectItem.cpp

diff --git a/src/battle/states/SelectItem.cpp b/src/battle/states/SelectItem.cpp
index 0291b739c9c2746b5b17f6f72edf58fabb203f57..045f3cc6f09e6fc7561b0efa5c8cc7d613cd7284 100644 (file)
--- a/src/battle/states/SelectItem.cpp
+++ b/src/battle/states/SelectItem.cpp
@@ -35,9 +35,9 @@ void SelectItem::ExitState(Application &c, SDL_Surface *screen) {
 }
 
 void SelectItem::ResumeState(Application &ctrl, SDL_Surface *screen) {
-       if (battle->ActiveHeroAttackChoice().Selection().HasSelected()) {
-               battle->ActiveHeroAttackChoice().SetType(AttackChoice::ITEM);
-               battle->ActiveHeroAttackChoice().SetItem(battle->GetItemMenu().Selected());
+       if (battle->ActiveHero().GetAttackChoice().Selection().HasSelected()) {
+               battle->ActiveHero().GetAttackChoice().SetType(AttackChoice::ITEM);
+               battle->ActiveHero().GetAttackChoice().SetItem(battle->GetItemMenu().Selected());
                ctrl.PopState();
        }
 }
@@ -55,26 +55,27 @@ void SelectItem::Resize(int width, int height) {
 void SelectItem::HandleEvents(const Input &input) {
        if (input.JustPressed(Input::ACTION_A)) {
                if (battle->GetItemMenu().SelectedIsEnabled()) {
+                       AttackChoice &ac(battle->ActiveHero().GetAttackChoice());
                        const Item *item(battle->GetItemMenu().Selected());
-                       battle->ActiveHeroAttackChoice().Selection().Reset();
+                       ac.Selection().Reset();
                        if (item->GetTargetingMode().TargetsAlly()) {
-                               battle->ActiveHeroAttackChoice().Selection().SelectHeroes();
+                               ac.Selection().SelectHeroes();
                        } else {
-                               battle->ActiveHeroAttackChoice().Selection().SelectEnemies();
+                               ac.Selection().SelectEnemies();
                        }
                        if (item->GetTargetingMode().TargetsAll()) {
-                               battle->ActiveHeroAttackChoice().SetType(AttackChoice::ITEM);
+                               ac.SetType(AttackChoice::ITEM);
                                // TODO: remove item from inventory
-                               battle->ActiveHeroAttackChoice().SetItem(item);
+                               ac.SetItem(item);
                                battle->NextHero();
                                ctrl->PopState();
                        } else {
                                if (item->GetTargetingMode().TargetsSingle()) {
-                                       battle->ActiveHeroAttackChoice().Selection().SetSingle();
+                                       ac.Selection().SetSingle();
                                } else {
-                                       battle->ActiveHeroAttackChoice().Selection().SetMultiple();
+                                       ac.Selection().SetMultiple();
                                }
-                               ctrl->PushState(new SelectTarget(battle, parent, &battle->ActiveHeroAttackChoice().Selection(), battle->Res().itemTargetCursor));
+                               ctrl->PushState(new SelectTarget(battle, parent, &ac.Selection(), battle->Res().itemTargetCursor));
                        }
                }
        }